-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default to slave mounting #158
Conversation
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
LGTM |
Enabling Homu for this repo is possible but we need to define the test suite. |
I'd love if we could test this before building for rhel, I have also a question for Vivek in the first comment |
I have been working on both PR and Homu in CentOS/sig-atomic-buildscripts#81 However it doesn't yet cover Docker because |
@ncdc @rhatdan this has broken docker when running integration tests:
|
@rhvgoyal ^^ |
Seems like it is a bogus test? |
I don't think so, it's not starting the container at all: Cannot start container e7f6029e0e2ce235e496a5a7bec7377eac1cad45f8c6f634b27be0b16d468249: Path /var/lib/docker/containers/e7f6029e0e2ce235e496a5a7bec7377eac1cad45f8c6f634b27be0b16d468249/resolv.conf is mounted on /var/lib/docker but it is not a shared or slave mount. |
docker run seems to work but you can't run "make test-integration-cli" because of that error - thus we cannot validate tests |
So containers won't start or just this test is failing? |
make test-integration-cli isn't working - if you docker run it works - but something is going on with tests and it's related to this patch :/ |
Ok so if your system is not setup as a slave mount then this blows up this test. |
@rhatdan alright, is this patch needed in fedora also? Because I didn't cherry-pick it, should I? |
I think so since OpenShift can not switch to the new method until the next release. |
We need to talk to Vivek when he gets in. |
alright |
It is complaining that you are trying to make a volume "slave" but it will not work because its parent mount has to be shared or slave for propagation to work. In this case looks like /var/lib/docker is the parent mount and looks like it is not "shared" or "slave". It must be "private". And that's why it fails. Who is mounting /var/lib/docker/ as "private"? |
I think that's the default on my Fedora 24 box Vivek (updated from F23) |
I think easiest fix is to convert these volume mounts to "rprivate". I don't think anybody is expecting any mount propagations on "resolv.conf" |
So default will be "rshared" but make these internally defined individual volumes to be "rprivate". That will ensure whatever user is mounting using "-v" will be mounted as "rshared". |
The same it's happening with |
I think so. Either we need to make "/var/lib/docker" "slave" or convert these individual volumes to "rprivate". I think later is safer approach as we are not expecting these docker defined volumes to be "shared". So yes, do the same for "shm" too. |
Fix BZ https://bugzilla.redhat.com/show_bug.cgi?id=1339146
@rhatdan @rhvgoyal @mrunalp @ncdc PTAL could this clash with @rhvgoyal's patches we backported here?
Signed-off-by: Antonio Murdaca runcom@redhat.com